feat(audit_trail): add new data source audit_trail_event #3445
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #3445 +/- ##
=========================================
- Coverage 1.78% 1.77% -0.01%
=========================================
Files 401 403 +2
Lines 44084 44205 +121
=========================================
- Hits 786 784 -2
- Misses 43211 43333 +122
- Partials 87 88 +1 ☔ View full report in Codecov by Sentry. |
estellesoulard
force-pushed
the
feat/audit-trail-event-data-source
branch
from
a2394cc to
fe22129
Compare
remyleone
reviewed
Nov 5, 2025
remyleone
reviewed
Nov 5, 2025
remyleone
reviewed
Nov 5, 2025
estellesoulard
force-pushed
the
feat/audit-trail-event-data-source
branch
2 times, most recently
from
51a35a1 to
93bf6a6
Compare
estellesoulard
force-pushed
the
feat/audit-trail-event-data-source
branch
from
93bf6a6 to
2f056d3
Compare
estellesoulard
force-pushed
the
feat/audit-trail-event-data-source
branch
from
f5a6215 to
12845fc
Compare
estellesoulard
force-pushed
the
feat/audit-trail-event-data-source
branch
from
0039116 to
982f867
Compare
estellesoulard
force-pushed
the
feat/audit-trail-event-data-source
branch
from
defd74e to
a8b738e
Compare
remyleone
reviewed
Nov 17, 2025
remyleone
reviewed
Nov 17, 2025
remyleone
reviewed
Nov 17, 2025
remyleone
reviewed
Nov 17, 2025
remyleone
reviewed
Nov 17, 2025
remyleone
reviewed
Nov 17, 2025
remyleone
reviewed
Nov 17, 2025
estellesoulard
force-pushed
the
feat/audit-trail-event-data-source
branch
4 times, most recently
from
875627d to
6f717c3
Compare
estellesoulard
force-pushed
the
feat/audit-trail-event-data-source
branch
from
6f717c3 to
0d4595d
Compare
remyleone
reviewed
Nov 20, 2025
| return nil, "", err | ||
| } | ||
| // In audit trail sdk-go so far only fr-par and nl-ams are supported | ||
| if !slices.Contains(api.Regions(), region) { |
Member
There was a problem hiding this comment.
I would prefer not to send an error from the provider side. In case we add new regions and the provider is not yet updated.
Contributor
Author
There was a problem hiding this comment.
Agreed! i removed this check ✔️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3427